mgaido91 commented on a change in pull request #24994: [SPARK-28133] Adding
inverse hyperbolic functions in SQL
URL: https://github.com/apache/spark/pull/24994#discussion_r298497414
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -617,6 +659,27 @@ case class Cot(child: Expression)
""")
case class Tanh(child: Expression) extends UnaryMathExpression(math.tanh,
"TANH")
+@ExpressionDescription(
+ usage = """
+ _FUNC_(expr) - Returns inverse hyperbolic tangent of `expr`.
+ """,
+ arguments = """
+ Arguments:
+ * expr - hyperbolic angle
+ """,
+ examples = """
+ Examples:
+ > SELECT _FUNC_(0);
+ 0.0
+ """)
+case class Atanh(child: Expression)
+ extends UnaryMathExpression((x: Double) => 0.5 * math.log((1.0 + x) / (1.0 -
x)), "ATANH") {
Review comment:
again, what if the input is negative?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
