squito commented on a change in pull request #24804: [SPARK-23472][CORE] Add
defaultJavaOptions for driver and executor.
URL: https://github.com/apache/spark/pull/24804#discussion_r298662689
##########
File path: docs/configuration.md
##########
@@ -470,6 +512,8 @@ Apart from these, the following properties are also
available, and may be useful
application ID and {{EXECUTOR_ID}} will be replaced by executor ID. For
example, to enable
verbose gc logging to a file named for the executor ID of the app in /tmp,
pass a 'value' of:
<code>-verbose:gc -Xloggc:/tmp/{{APP_ID}}-{{EXECUTOR_ID}}.gc</code>
+
+ <code>spark.executor.defaultJavaOptions</code> prepended (without any
parameter override) to this configuration.
Review comment:
I think maybe just leaving the part about parameter overriding is more
clear, as that is what prepending means. Its just not clear what parameters
and what overriding you're talking about, which ends up making it more
confusing.
If you do want to explain it in more detail, I think you've got to spend
more time going into those details, with a small example (as you did in this
comment here). But IMO not necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
