Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3870#issuecomment-69479152
Thanks for figuring this out and proposing a solution! I guess our test
cases missed this since they always perform later column reordering.
I'm a little concerned about the performance impact of this part of the
change though:
```scala
// Fill outputRow with iter.next()._2 at the correct indexes using
normalOutputIndexes
iter.next()._2
.zipWithIndex
.foreach(nI => outputRow(normalOutputIndexes(nI._2)) = nI._1)
new GenericRow(outputRow)
```
It's both functional programming (which I normally love, but try to avoid
in per-tuple codepaths) and allocates an object.
What do you think of the approach I took in #3990?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
