gatorsmile commented on a change in pull request #24972:
[WIP][SPARK-28167][SQL] Show global temporary view in database tool
URL: https://github.com/apache/spark/pull/24972#discussion_r298813556
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -775,32 +775,61 @@ class SessionCatalog(
* Note that, if the specified database is global temporary view database,
we will list global
* temporary views.
*/
- def listTables(db: String): Seq[TableIdentifier] = listTables(db, "*")
Review comment:
Yes. Definitely, we should not change the semantics of listTable API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
