mgaido91 commented on a change in pull request #25016: [SPARK-28200][SQL]
Decimal overflow handling in ExpressionEncoder
URL: https://github.com/apache/spark/pull/25016#discussion_r298933875
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala
##########
@@ -162,6 +162,32 @@ class RowEncoderSuite extends CodegenInterpretedPlanTest {
assert(row.toSeq(schema).head == decimal)
}
+ test("RowEncoder should respect nullOnOverflow for decimals") {
+ val schema = new StructType().add("decimal", DecimalType.SYSTEM_DEFAULT)
+ testDecimalOverflow(schema, Row(BigDecimal("9" * 100)))
+ testDecimalOverflow(schema, Row(new java.math.BigDecimal("9" * 100)))
+ }
+
+ private def testDecimalOverflow(schema: StructType, row: Row): Unit = {
+ withSQLConf(SQLConf.DECIMAL_OPERATIONS_NULL_ON_OVERFLOW.key ->
false.toString) {
+ val encoder = RowEncoder(schema).resolveAndBind()
+ intercept[Exception] {
+ encoder.toRow(row)
+ } match {
+ case e: ArithmeticException =>
+ assert(e.getMessage.contains("cannot be represented as Decimal"))
+ case e: RuntimeException =>
+ assert(e.getCause.isInstanceOf[ArithmeticException])
+ assert(e.getCause.getMessage.contains("cannot be represented as
Decimal"))
+ }
+ }
+
+ withSQLConf(SQLConf.DECIMAL_OPERATIONS_NULL_ON_OVERFLOW.key ->
true.toString) {
Review comment:
```suggestion
withSQLConf(SQLConf.DECIMAL_OPERATIONS_NULL_ON_OVERFLOW.key -> "true") {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
