HeartSaVioR commented on a change in pull request #24996: [SPARK-28199][SS]
Remove usage of deprecated ProcessingTime in Spark codebase
URL: https://github.com/apache/spark/pull/24996#discussion_r299218577
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousExecution.scala
##########
@@ -93,7 +93,7 @@ class ContinuousExecution(
}
private val triggerExecutor = trigger match {
- case ContinuousTrigger(t) => ProcessingTimeExecutor(ProcessingTime(t),
triggerClock)
+ case ContinuousTrigger(t) =>
ProcessingTimeExecutor(ProcessingTimeTrigger(t), triggerClock)
Review comment:
Trigger.xxx returns `Trigger`, whereas it requires `ProcessingTimeTrigger`
(was requiring `ProcessingTime`). From user-facing API we avoid dealing with
actual implementations via only exposing `Trigger` but internally we require
actual implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
