wypoon commented on a change in pull request #23767: [SPARK-26329][CORE] Faster 
polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r299249267
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
 ##########
 @@ -254,12 +267,18 @@ private[spark] class Executor(
 
   def stop(): Unit = {
     env.metricsSystem.report()
+    try {
 
 Review comment:
   As you acknowledge, `Utils.tryLogNonFatalError` does not allow you to 
customize the message to log and more importantly, logs the message as an 
error. We only want to log a warning.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to