Github user advancedxy commented on the pull request:
https://github.com/apache/spark/pull/2874#issuecomment-69500291
Hi @SaintBacchus, I get the idea that there is a limit in the seq size. But
I don't think the buggy code is from implementation you listed. The actually
buggy code is the first case in the pattern matching.
``` Scala
case r: Range.Inclusive => {
val sign = if (r.step < 0) {
-1
} else {
1
}
slice(new Range(
r.start, r.end + sign, r.step).asInstanceOf[Seq[T]], numSlices)
// r.end + sign is overflow
}
```
We should consider fix that bug. @srowen and @andrewor14, do you think we
need another pr?
@SaintBacchus do you think you have time for that? I can contribute my work
if you are busy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
