cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r299348377
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/ShuffleBlockResolver.scala
##########
@@ -34,7 +34,7 @@ trait ShuffleBlockResolver {
* Retrieve the data for the specified block. If the data for that block is
not available,
* throws an unspecified exception.
*/
- def getBlockData(blockId: ShuffleBlockId): ManagedBuffer
+ def getBlockData(shuffleGenerationId: Int, blockId: ShuffleBlockId):
ManagedBuffer
Review comment:
seems better to make it `def getBlockData(shuffleId: Int,
shuffleGenerationId: Int, mapId...)` if there are not many existing callers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
