maropu commented on a change in pull request #25001: [SPARK-28083][SQL] Enhance 
ANSI SQL: LIKE predicate: ESCAPE clause.
URL: https://github.com/apache/spark/pull/25001#discussion_r299362424
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
 ##########
 @@ -65,6 +65,59 @@ abstract class StringRegexExpression extends 
BinaryExpression
   override def sql: String = s"${left.sql} 
${prettyName.toUpperCase(Locale.ROOT)} ${right.sql}"
 }
 
+abstract class StringRegexV2Expression extends TernaryExpression
 
 Review comment:
   Have you tried this?
   ```
   case class Like(
     inputExpr: Expression,
     patternExpr: Expression,
     escapeExpr: Option[String] = None) extends StringRegexExpression
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to