cloud-fan commented on a change in pull request #24960: [SPARK-28156][SQL]
Self-join should not miss cached view
URL: https://github.com/apache/spark/pull/24960#discussion_r299384817
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
##########
@@ -47,8 +52,12 @@ import org.apache.spark.sql.internal.SQLConf
* This should be only done after the batch of Resolution, because the view
attributes are not
* completely resolved during the batch of Resolution.
*/
-case class AliasViewChild(conf: SQLConf) extends Rule[LogicalPlan] with
CastSupport {
- override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperatorsUp
{
+object EliminateView extends Rule[LogicalPlan] with CastSupport {
Review comment:
We still need a rule in analyzer to make sure the view is valid... We can
put it in `CheckAnalysis`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
