HyukjinKwon commented on a change in pull request #24637: [SPARK-27707][SQL] 
Prune unnecessary nested fields from Generate in explode
URL: https://github.com/apache/spark/pull/24637#discussion_r299436572
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -588,6 +588,16 @@ object ColumnPruning extends Rule[LogicalPlan] {
         .map(_._2)
       p.copy(child = g.copy(child = newChild, unrequiredChildIndex = 
unrequiredIndices))
 
+    // prune unrequired nested fields
+    case p @ Project(projectList, g: Generate) =>
 
 Review comment:
   Out of curiosity, why don't we need another configuration then if 
`spark.sql.optimizer.nestedSchemaPruning.enabled` isn't part of this 
optimization, or fixing the doc of 
`spark.sql.optimizer.nestedSchemaPruning.enabled`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to