HyukjinKwon commented on a change in pull request #24994: [SPARK-28133] Adding
inverse hyperbolic functions in SQL
URL: https://github.com/apache/spark/pull/24994#discussion_r299761911
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -2023,11 +2041,29 @@ object functions {
/**
* @param columnName hyperbolic angle
- * @return hyperbolic sine of the given value, as if computed by
`java.lang.Math.sinh`
+ * @return inverse hyperbolic sine of the given value
*
* @group math_funcs
- * @since 1.4.0
+ * @since 3.0.0
*/
+ def asinh(columnName: String): Column = asinh(Column(columnName))
Review comment:
Sorry I had to clarify it. Yes, let's add it only into SQL side and remove
them in Scala, Python and R per
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L42-L56
These are only added into other language APIs when they are commonly used. I
think we don't have to add them in the first place in general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
