HeartSaVioR commented on a change in pull request #24999: [SPARK-28142][SS][TEST][FOLLOWUP] Add configuration check test on Kafka continuous stream URL: https://github.com/apache/spark/pull/24999#discussion_r299777784
########## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceProviderSuite.scala ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.kafka010 + +import java.util.Locale + +import scala.collection.JavaConverters._ + +import org.scalatest.PrivateMethodTester + +import org.apache.spark.SparkFunSuite +import org.apache.spark.sql.sources.v2.reader.Scan +import org.apache.spark.sql.util.CaseInsensitiveStringMap + +class KafkaSourceProviderSuite extends SparkFunSuite with PrivateMethodTester { + private val pollTimeoutMsMethod = PrivateMethod[Long]('pollTimeoutMs) + + test("SPARK-28142 - continuous mode - options should be handled as case-insensitive") { Review comment: Same here. I guess I would just add test here to ensure they are being reused. Maybe the test would fail given #24967 is a patch for that, but we can comment here and in #24967 we can uncomment. Let me update the PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
