Tonix517 commented on a change in pull request #25041: [SPARK-28133][SQL] Add
acosh/asinh/atanh functions
URL: https://github.com/apache/spark/pull/25041#discussion_r299781765
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -1559,6 +1559,15 @@ object functions {
*/
def cosh(columnName: String): Column = cosh(Column(columnName))
+ /**
+ * @param e hyperbolic angle
+ * @return inverse hyperbolic sine of the given value
+ *
+ * @group math_funcs
+ * @since 3.0.0
+ */
+ def acosh(e: Column): Column = withExpr { Acosh(e.expr) }
Review comment:
According to @HyukjinKwon , asinh\acosh\atanh should not be included in this
file. missed to remove these. now all removed from functions.scala. thanks for
finding this out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
