peter-toth commented on a change in pull request #24831: [SPARK-19799][SQL]
Support WITH clause in subqueries
URL: https://github.com/apache/spark/pull/24831#discussion_r299808386
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -211,37 +211,6 @@ class Analyzer(
CleanupAliases)
)
- /**
- * Analyze cte definitions and substitute child plan with analyzed cte
definitions.
- */
- object CTESubstitution extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUp {
- case With(child, relations) =>
- // substitute CTE expressions right-to-left to resolve references to
previous CTEs:
- // with a as (select * from t), b as (select * from a) select * from b
- relations.foldRight(child) {
- case ((cteName, ctePlan), currentPlan) =>
- substituteCTE(currentPlan, cteName, ctePlan)
- }
- case other => other
- }
-
- def substituteCTE(plan: LogicalPlan, cteName: String, ctePlan:
LogicalPlan): LogicalPlan = {
- plan resolveOperatorsUp {
- case UnresolvedRelation(Seq(table)) if resolver(cteName, table) =>
- ctePlan
- case u: UnresolvedRelation =>
Review comment:
I don't think this line does anything nor `UnresolvedRelation` can have an
expression so I thought it is safe and good idea to remove it. Please correct
me if I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
