mgaido91 commented on a change in pull request #24831: [SPARK-19799][SQL]
Support WITH clause in subqueries
URL: https://github.com/apache/spark/pull/24831#discussion_r299826510
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -226,20 +226,20 @@ class Analyzer(
case other => other
}
- def substituteCTE(plan: LogicalPlan, cteName: String, ctePlan:
LogicalPlan): LogicalPlan = {
+ private def substituteCTE(
+ plan: LogicalPlan,
+ cteName: String,
+ ctePlan: LogicalPlan): LogicalPlan =
Review comment:
may you please keep the `{`. I think in general we are trying to always use
them in order to help readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
