mgaido91 commented on a change in pull request #25033: [SPARK-28224][SQL]
Aggregate sum large decimals
URL: https://github.com/apache/spark/pull/25033#discussion_r299831798
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestData.scala
##########
@@ -91,6 +91,14 @@ private[sql] trait SQLTestData { self =>
df
}
+ protected lazy val largeDecimals: DataFrame = {
+ val df = spark.sparkContext.parallelize(
+ DecimalData(BigDecimal("1"* 20 + ".123"), BigDecimal("1"* 20 + ".123"))
::
+ DecimalData(BigDecimal("9"* 20 + ".123"), BigDecimal("9"* 20 + ".123"))
:: Nil).toDF()
+ df.createOrReplaceTempView("largeDecimals")
Review comment:
well, if others think it is ok to leave it I am fine with it, I'd remove it
since it is useless honestly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
