mgaido91 commented on a change in pull request #25055: [SPARK-28189][SQL] Use
semanticEquals in Dataset drop method for attributes comparison
URL: https://github.com/apache/spark/pull/25055#discussion_r300548345
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -2322,7 +2322,7 @@ class Dataset[T] private[sql](
}
val attrs = this.logicalPlan.output
val colsAfterDrop = attrs.filter { attr =>
- attr != expression
+ !attr.semanticEquals(expression)
Review comment:
There are other places. Please see
https://github.com/apache/spark/pull/21449.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
