gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r300669900
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDbStateStoreSuite.scala ########## @@ -0,0 +1,615 @@ +/* Review comment: +1 on this, just reached this area and remarked the same things. I would vote on the same approach, let's assume it works the same way and make exceptions with a reason. You can take a look at DSv1 and DSv2 tests, the common behavior is in the base class and the difference is in the specialized class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
