Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/3999#discussion_r22803087
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -120,8 +122,10 @@ private[sql] class DDLParser extends
StandardTokenParsers with PackratParsers wi
protected lazy val pair: Parser[(String, String)] = ident ~ stringLit ^^
{ case k ~ v => (k,v) }
protected lazy val column: Parser[StructField] =
- ident ~ dataType ^^ { case columnName ~ typ =>
- StructField(columnName, typ)
+ ident ~ dataType ~ (COMMENT ~> stringLit).? ^^ { case columnName ~
typ ~ cm =>
+ val metadata = new MetadataBuilder()
+ .putString(COMMENT.str.toLowerCase(), cm.getOrElse("")).build()
+ StructField(columnName, typ, true, metadata)
--- End diff --
I think the test failure will be resolved once we do not create a
`metadata` if there is no comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
