rdblue commented on a change in pull request #24768: [SPARK-27919][SQL] Add v2
session catalog
URL: https://github.com/apache/spark/pull/24768#discussion_r300768382
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UpdateAttributeNullability.scala
##########
@@ -37,7 +37,7 @@ object UpdateAttributeNullability extends Rule[LogicalPlan] {
case p if !p.resolved => p
// Skip leaf node, as it has no child and no need to update nullability.
case p: LeafNode => p
- case p: LogicalPlan =>
+ case p: LogicalPlan if p.childrenResolved =>
Review comment:
@cloud-fan, not necessarily. Some plans may not check that children are
resolved. `CheckAnalysis` accounts for this case by using `foreachUp`:
```scala
plan.foreachUp {
case o if !o.resolved =>
failAnalysis(s"unresolved operator
${o.simpleString(SQLConf.get.maxToStringFields)}")
case _ =>
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
