HeartSaVioR commented on a change in pull request #24996: [SPARK-28199][SS]
Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end
users
URL: https://github.com/apache/spark/pull/24996#discussion_r300817205
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
##########
@@ -27,3 +32,34 @@ import org.apache.spark.sql.streaming.Trigger
@Experimental
@Evolving
case object OneTimeTrigger extends Trigger
+
+/**
+ * A [[Trigger]] that runs a query periodically based on the processing time.
If `interval` is 0,
+ * the query will run as fast as possible.
+ */
+@Evolving
+private[sql] case class ProcessingTimeTrigger(intervalMs: Long) extends
Trigger {
Review comment:
We might need to keep original class as we haven't deprecated it yet, and to
allow end users to only create Trigger implementations as `Trigger.xxx`, we may
also want to deprecated some more classes as well.
The change may look like below commit:
https://github.com/HeartSaVioR/spark/commit/f8488cfb0a045806e125215b933fc10931b1b431
IMHO this could be considered as another issue as more deprecations are
happening. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
