dongjoon-hyun commented on a change in pull request #25063: [SPARK-28267][DOC] Update building-spark.md(build with Hive 2.3) URL: https://github.com/apache/spark/pull/25063#discussion_r300906838
########## File path: docs/building-spark.md ########## @@ -70,6 +70,8 @@ This will build Spark distribution along with Python pip and R packages. For mor ## Specifying the Hadoop Version and Enabling YARN +You can enable the exact profile of Hadoop to compile against through `-Phadoop-2.7`(default) and `-Phadoop-3.2`. + Review comment: Here, `exact profile` might look strange because we also have `hadoop-provided` profile. What about just omitting this line 73~74? The following example (82~84) looks clear enough to me (although it's an implicit way.) Also, could you update the PR title because this PR includes `hadoop` example update additionally? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
