juliuszsompolski commented on a change in pull request #25062:
[SPARK-28260][SQL] Add CLOSED state to ExecutionState
URL: https://github.com/apache/spark/pull/25062#discussion_r301008991
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
##########
@@ -254,6 +254,11 @@ object HiveThriftServer2 extends Logging {
trimExecutionIfNecessary()
}
+ def onOperationClosed(id: String): Unit = synchronized {
+ executionList(id).finishTimestamp = System.currentTimeMillis
Review comment:
I would add a separate field `closedTimestamp`, and add a separate column in
the tables in the UI (overall and within session). Both the time it finished
execution, and was closed are interesting information to show - a long time
between finished and closed shows that it spent a lot of time returning the
result.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
