Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4009#discussion_r22822163
--- Diff: build/mvn ---
@@ -142,8 +142,25 @@ if [ -n "${ZINC_INSTALL_FLAG}" -o -z "`${ZINC_BIN}
-status`" ]; then
-scala-library "${SCALA_LIBRARY}" &>/dev/null
fi
+# Find the java binary
+if [ -n "${JAVA_HOME}" ]; then
+ RUNNER="${JAVA_HOME}/bin/java"
+else
+ if [ `command -v java` ]; then
+ RUNNER="java"
+ else
+ echo "JAVA_HOME is not set" >&2
+ exit 1
+ fi
+fi
+JAVA_VERSION=$("$RUNNER" -version 2>&1 | grep 'version' | sed 's/.*
version "\(.*\)\.\(.*\)\..*"/\1\2/; 1q')
--- End diff --
This is copied from `spark-class` right?
I wonder, is it worth this complexity just to avoid an ignorable warning in
Java 8?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
