itsvikramagr commented on a change in pull request #24922: [SPARK-28120][SS]
Rocksdb state storage implementation
URL: https://github.com/apache/spark/pull/24922#discussion_r301023026
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
##########
@@ -198,6 +198,58 @@ class StateStoreSuite extends
StateStoreSuiteBase[HDFSBackedStateStoreProvider]
assert(loadedMaps.size() === 0)
}
+ test("get, put, remove, commit, and all data iterator") {
Review comment:
RocksDB gives an estimate of the number of keys present (See
https://github.com/facebook/rocksdb/wiki/RocksDB-FAQ). For HDFSStateProvider,
we are checking the metrics which works well. For RocksDB, I was unable to get
the correct value from the backend when we insert a few records.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
