HeartSaVioR commented on a change in pull request #25048: [SPARK-28247][SS] Fix flaky test "query without test harness" on ContinuousSuite URL: https://github.com/apache/spark/pull/25048#discussion_r301155735
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala ########## @@ -36,6 +38,9 @@ class RateStreamContinuousStream(rowsPerSecond: Long, numPartitions: Int) extend val perPartitionRate = rowsPerSecond.toDouble / numPartitions.toDouble + private[sql] val highestCommittedValue = new AtomicLong(Long.MinValue) + private[sql] val firstCommittedTime = new AtomicLong(Long.MinValue) Review comment: Stream query listener is not ready for continuous processing. #24537 is trying to address it, but seems like it's not ready. Actually the query listener mainly reports per batch to show changing numbers, and if we apply this to continuous processing, the report could be far behind if there's skew among partitions and epochs for partitions differ. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
