tgravescs commented on a change in pull request #25047:
[WIP][SPARK-27371][CORE] Support GPU-aware resources scheduling in Standalone
URL: https://github.com/apache/spark/pull/25047#discussion_r301177434
##########
File path:
core/src/main/scala/org/apache/spark/deploy/worker/DriverRunner.scala
##########
@@ -171,16 +174,20 @@ private[deploy] class DriverRunner(
private[worker] def prepareAndRunDriver(): Int = {
val driverDir = createWorkingDirectory()
val localJarFilename = downloadUserJar(driverDir)
+ val resourceFile = ResourceUtils.prepareResourceFile(SPARK_DRIVER_PREFIX,
resources, driverDir)
def substituteVariables(argument: String): String = argument match {
case "{{WORKER_URL}}" => workerUrl
case "{{USER_JAR}}" => localJarFilename
case other => other
}
+ // config resource file for driver, which would be used to load resources
when driver starts up
+ val javaOpts = driverDesc.command.javaOpts ++
+ Seq(s"-D${DRIVER_RESOURCES_FILE.key}=${resourceFile.getAbsolutePath}")
Review comment:
always sending this, vs only when actually needs resources? I assume the
file is empty if it doesn't need any?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
