dongjoon-hyun commented on a change in pull request #24967: [SPARK-28163][SS] Use CaseInsensitiveMap for KafkaOffsetReader URL: https://github.com/apache/spark/pull/24967#discussion_r301202516
########## File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchStream.scala ########## @@ -56,7 +56,7 @@ import org.apache.spark.util.UninterruptibleThread * and not use wrong broker addresses. */ private[kafka010] class KafkaMicroBatchStream( - kafkaOffsetReader: KafkaOffsetReader, + private val offsetReader: KafkaOffsetReader, Review comment: - Is `private val` required for `Use CaseInsensitiveMap for KafkaOffsetReader`? - Is the renaming from `kafkaOffsetReader` to `offsetReader` required for `Use CaseInsensitiveMap for KafkaOffsetReader`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
