srowen commented on a change in pull request #25075: [SPARK-28261][CORE] Fix
client reuse test
URL: https://github.com/apache/spark/pull/25075#discussion_r301220671
##########
File path:
common/network-common/src/test/java/org/apache/spark/network/TransportClientFactorySuite.java
##########
@@ -117,7 +117,7 @@ private void testClientReuse(int maxConnections, boolean
concurrent)
}
Assert.assertEquals(0, failed.get());
- Assert.assertEquals(clients.size(), maxConnections);
+ Assert.assertTrue(clients.size() <= maxConnections);
Review comment:
I suppose there's no way to ask it to not return a cached instance?
This seems to be testing that they're all different, but, that doesn't seem
to be the current behavior, nor is it necessarily desirable. So, OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
