HeartSaVioR commented on a change in pull request #24996: [SPARK-28199][SS]
Replace deprecated ProcessingTime with ProcessingTimeTrigger and make invisible
to end users
URL: https://github.com/apache/spark/pull/24996#discussion_r301359455
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
##########
@@ -27,3 +32,34 @@ import org.apache.spark.sql.streaming.Trigger
@Experimental
@Evolving
case object OneTimeTrigger extends Trigger
+
+/**
+ * A [[Trigger]] that runs a query periodically based on the processing time.
If `interval` is 0,
+ * the query will run as fast as possible.
+ */
+@Evolving
+private[sql] case class ProcessingTimeTrigger(intervalMs: Long) extends
Trigger {
Review comment:
Could we define the boundary of the PR - I guess if we want to address @tdas
suggestion, it is going to be more than
https://github.com/HeartSaVioR/spark/commit/f8488cfb0a045806e125215b933fc10931b1b431
, including moving `OneTimeTrigger` to `Triggers.scala` (with deprecating
origin).
Just wanted to be clear how much we want to do in this PR.
And one more question, `Triggers.scala` belongs to
`org.apache.spark.sql.execution.streaming` package - would it be hidden from
API docs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
