Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3916#discussion_r22840454
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractLauncher.java ---
@@ -0,0 +1,600 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.launcher;
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.FileFilter;
+import java.io.FileInputStream;
+import java.io.InputStreamReader;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Enumeration;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+import java.util.jar.JarEntry;
+import java.util.jar.JarFile;
+import java.util.regex.Pattern;
+
+/**
+ * Basic functionality for launchers.
+ */
+public abstract class AbstractLauncher<T extends AbstractLauncher> extends
LauncherCommon {
+
+ protected static final String DEFAULT_MEM = "512m";
+
+ protected String javaHome;
+ protected String sparkHome;
+ protected String propertiesFile;
+ protected final Map<String, String> conf = new HashMap<String, String>();
+ private final Map<String, String> env;
+
+ protected AbstractLauncher() {
+ this(null);
+ }
+
+ protected AbstractLauncher(Map<String, String> env) {
+ this.env = env;
+ }
+
+ @SuppressWarnings("unchecked")
+ private final T THIS = (T) this;
+
+ /** Set a custom JAVA_HOME for launching the Spark application. */
+ public T setJavaHome(String path) {
+ checkNotNull(path, "path");
+ this.javaHome = path;
+ return THIS;
+ }
+
+ /** Set a custom Spark installation location for the application. */
+ public T setSparkHome(String path) {
+ checkNotNull(path, "path");
+ this.sparkHome = path;
+ return THIS;
+ }
+
+ /** Set a custom properties file with Spark configuration for the
application. */
+ public T setPropertiesFile(String path) {
+ checkNotNull(path, "path");
+ this.propertiesFile = path;
+ return THIS;
+ }
+
+ /** Set a single configuration value for the application. */
+ public T setConf(String key, String value) {
+ checkNotNull(key, "key");
+ checkNotNull(value, "value");
+ checkArgument(key.startsWith("spark."), "'key' must start with
'spark.'");
+ conf.put(key, value);
+ return THIS;
+ }
+
+ /**
+ * Launchers should implement this to create the command to be executed.
+ */
+ protected abstract List<String> buildLauncherCommand() throws
IOException;
+
+ protected Properties loadPropertiesFile() throws IOException {
+ Properties props = new Properties();
+ File propsFile;
+ if (propertiesFile != null) {
+ propsFile = new File(propertiesFile);
+ checkArgument(propsFile.isFile(), "Invalid properties file '%s'.",
propertiesFile);
+ } else {
+ String confDir = getenv("SPARK_CONF_DIR");
+ if (confDir == null) {
+ confDir = join(File.separator, getSparkHome(), "conf");
+ }
+ propsFile = new File(confDir, "spark-defaults.conf");
--- End diff --
could you make `spark-defaults.conf` a static variable
`DEFAULT_PROPERTIES_FILE` or something
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
