dongjoon-hyun commented on a change in pull request #24969: [SPARK-28151][SQL]
Fix MsSqlServerDialect Byte/Short/Float type mappings
URL: https://github.com/apache/spark/pull/24969#discussion_r301778445
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -550,7 +550,7 @@ object JdbcUtils extends Logging {
case ByteType =>
(stmt: PreparedStatement, row: Row, pos: Int) =>
- stmt.setInt(pos + 1, row.getByte(pos))
+ stmt.setByte(pos + 1, row.getByte(pos))
Review comment:
What I meant is like your 2nd option.
> 2nd PR with complete ByteType fix with more elaborate integration test.
Here, the proper regression test means a test causing failure for the other
Dialects. (e.g. PostgreSQL/MySQL/...) because `JdbcUtils` is shared across
Dialects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
