maropu commented on a change in pull request #25082: [SPARK-28310][SQL] Support ANSI SQL grammar:first_value/last_value(expression, [ignore/respect nulls]) URL: https://github.com/apache/spark/pull/25082#discussion_r301832682
########## File path: docs/sql-keywords.md ########## @@ -159,6 +160,7 @@ Below is a list of all the keywords in Spark SQL. <tr><td>LIMIT</td><td>non-reserved</td><td>non-reserved</td><td>non-reserved</td></tr> <tr><td>LINES</td><td>non-reserved</td><td>non-reserved</td><td>non-reserved</td></tr> <tr><td>LIST</td><td>non-reserved</td><td>non-reserved</td><td>non-reserved</td></tr> + <tr><td>LIST_VALUE</td><td>non-reserved</td><td>non-reserved</td><td>reserved</td></tr> Review comment: I think the two words should be reserved in spark (ansi=true). Also, you need to update `TableIdentifierParserSuite`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
