imback82 opened a new pull request #25090: [SPARK-28278][SQL][PYTHON][TESTS] 
Convert and port 'except-all.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25090
 
 
   ## What changes were proposed in this pull request?
   
   This PR adds some tests converted from `except-all.sql` to test UDFs. Please 
see contribution guide of this umbrella ticket - 
[SPARK-27921](https://issues.apache.org/jira/browse/SPARK-27921).
   
   <details><summary>Diff comparing to 'except-all.sql'</summary>
   <p>
   
   ```diff
   diff --git 
a/sql/core/src/test/resources/sql-tests/results/except-all.sql.out 
b/sql/core/src/test/resources/sql-tests/results/udf/udf-except-all.sql.out
   index 01091a2f75..d00eded213 100644
   --- a/sql/core/src/test/resources/sql-tests/results/except-all.sql.out
   +++ 
b/sql/core/src/test/resources/sql-tests/results/udf/udf-except-all.sql.out
   @@ -77,7 +77,7 @@ NULL
    -- !query 6
    SELECT * FROM tab1
    EXCEPT ALL
   -SELECT * FROM tab2 WHERE c1 IS NOT NULL
   +SELECT * FROM tab2 WHERE udf(c1) IS NOT NULL
    -- !query 6 schema
    struct<c1:int>
    -- !query 6 output
   @@ -85,11 +85,10 @@ struct<c1:int>
    2
    2
    NULL
   -NULL
   
   
    -- !query 7
   -SELECT * FROM tab1 WHERE c1 > 5
   +SELECT * FROM tab1 WHERE udf(c1) > 5
    EXCEPT ALL
    SELECT * FROM tab2
    -- !query 7 schema
   @@ -101,7 +100,7 @@ struct<c1:int>
    -- !query 8
    SELECT * FROM tab1
    EXCEPT ALL
   -SELECT * FROM tab2 WHERE c1 > 6
   +SELECT * FROM tab2 WHERE c1 > udf(6)
    -- !query 8 schema
    struct<c1:int>
    -- !query 8 output
   @@ -119,7 +118,7 @@ NULL
    -- !query 9
    SELECT * FROM tab1
    EXCEPT ALL
   -SELECT CAST(1 AS BIGINT)
   +SELECT CAST(udf(1) AS BIGINT)
    -- !query 9 schema
    struct<c1:bigint>
    -- !query 9 output
   @@ -260,40 +259,40 @@ struct<k:int,v:int>
    -- !query 20
    SELECT *
   -FROM   (SELECT tab3.k,
   -               tab4.v
   +FROM   (SELECT udf(tab3.k),
   +               udf(tab4.v)
            FROM   tab3
                   JOIN tab4
                     ON tab3.k = tab4.k)
    EXCEPT ALL
    SELECT *
   -FROM   (SELECT tab3.k,
   -               tab4.v
   +FROM   (SELECT udf(tab3.k),
   +               udf(tab4.v)
            FROM   tab3
                   JOIN tab4
                     ON tab3.k = tab4.k)
    -- !query 20 schema
   -struct<k:int,v:int>
   +struct<udf(k):string,udf(v):string>
    -- !query 20 output
   
   
   
    -- !query 21
    SELECT *
   -FROM   (SELECT tab3.k,
   -               tab4.v
   +FROM   (SELECT udf(tab3.k),
   +               udf(tab4.v)
            FROM   tab3
                   JOIN tab4
                     ON tab3.k = tab4.k)
    EXCEPT ALL
    SELECT *
   -FROM   (SELECT tab4.v AS k,
   -               tab3.k AS v
   +FROM   (SELECT udf(tab4.v) AS k,
   +               udf(tab3.k) AS v
            FROM   tab3
                   JOIN tab4
                     ON tab3.k = tab4.k)
    -- !query 21 schema
   -struct<k:int,v:int>
   +struct<udf(k):string,udf(v):string>
    -- !query 21 output
    1      2
    1      2
   @@ -305,11 +304,11 @@ struct<k:int,v:int>
   
    -- !query 22
   -SELECT v FROM tab3 GROUP BY v
   +SELECT udf(v) FROM tab3 GROUP BY v
    EXCEPT ALL
   -SELECT k FROM tab4 GROUP BY k
   +SELECT udf(k) FROM tab4 GROUP BY k
    -- !query 22 schema
   -struct<v:int>
   +struct<udf(v):string>
    -- !query 22 output
    3
   
   ```
   </p>
   </details> 
   
   ## How was this patch tested?
   
   Tested as guided in 
[SPARK-27921](https://issues.apache.org/jira/browse/SPARK-27921).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to