MaxGekk commented on a change in pull request #25097: [SPARK-28015][SQL] Check stringToDate() consumes entire input for the yyyy and yyyy-[m]m formats URL: https://github.com/apache/spark/pull/25097#discussion_r302146142
########## File path: sql/core/src/test/resources/sql-tests/results/pgSQL/date.sql.out ########## @@ -198,17 +198,29 @@ struct<DATE '1999-01-18':date> -- !query 21 SELECT date '1999 Jan 08' -- !query 21 schema -struct<DATE '1999-01-01':date> +struct<> -- !query 21 output -1999-01-01 Review comment: The result is wrong, it is better to throw the exception because the format with spaces (`yyyy [m]m [d]d`) is not supported currently. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
