dongjoon-hyun commented on a change in pull request #25096:
[SPARK-28334][SQL][TEST] Port select.sql
URL: https://github.com/apache/spark/pull/25096#discussion_r302173707
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -487,6 +487,32 @@ class SQLQueryTestSuite extends QueryTest with
SharedSQLContext {
""".stripMargin)
.load(testFile("test-data/postgresql/tenk.data"))
.createOrReplaceTempView("tenk1")
+
+ session
+ .read
+ .format("csv")
+ .options(Map("delimiter" -> "\t", "header" -> "false"))
+ .schema(
+ """
+ |unique1 int,
+ |unique2 int,
+ |two int,
+ |four int,
+ |ten int,
+ |twenty int,
+ |hundred int,
+ |thousand int,
+ |twothousand int,
+ |fivethous int,
+ |tenthous int,
+ |odd int,
+ |even int,
+ |stringu1 string,
+ |stringu2 string,
+ |string4 string
+ """.stripMargin)
+ .load(testFile("test-data/postgresql/onek.data"))
+ .createOrReplaceTempView("onek2")
Review comment:
If this is for only `select.sql`, can we simply like the following? Maybe,
we can have the following line at line 464.
```scala
session.table("onek").createOrReplaceTempView("onek2")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
