srowen commented on a change in pull request #24996: [SPARK-28199][SS] Move
Trigger implementations to Triggers.scala and avoid exposing these to the end
users
URL: https://github.com/apache/spark/pull/24996#discussion_r302204601
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
##########
@@ -17,13 +17,94 @@
package org.apache.spark.sql.execution.streaming
+import java.util.concurrent.TimeUnit
+
+import scala.concurrent.duration.Duration
+
import org.apache.spark.annotation.{Evolving, Experimental}
import org.apache.spark.sql.streaming.Trigger
+import org.apache.spark.unsafe.types.CalendarInterval
+
+private[sql] object TriggerIntervalUtils {
Review comment:
Yeah OK they're reused across the implementation in this file. Seems OK but
I think you can declare it `private` even? I wasn't getting at a `trait` or
anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
