dongjoon-hyun commented on a change in pull request #25071: [SPARK-28292][SQL]
Enable inject user-defined Hint
URL: https://github.com/apache/spark/pull/25071#discussion_r302207790
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
##########
@@ -16,18 +16,20 @@
*/
package org.apache.spark.sql
+import java.util.Locale
+
import org.apache.spark.{SparkFunSuite, TaskContext}
import org.apache.spark.internal.Logging
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.catalyst.{FunctionIdentifier, TableIdentifier}
import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.parser.{CatalystSqlParser,
ParserInterface}
-import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
+import org.apache.spark.sql.catalyst.plans.logical.{GlobalLimit, LocalLimit,
LogicalPlan, UnresolvedHint}
import org.apache.spark.sql.catalyst.rules.Rule
import org.apache.spark.sql.execution._
import org.apache.spark.sql.execution.vectorized.OnHeapColumnVector
import org.apache.spark.sql.types.{DataType, Decimal, IntegerType, LongType,
Metadata, StructType}
-import org.apache.spark.sql.vectorized.{ColumnarArray, ColumnarBatch,
ColumnarMap, ColumnVector}
+import org.apache.spark.sql.vectorized.{ColumnarArray, ColumnVector,
ColumnarBatch, ColumnarMap}
Review comment:
Please fix this.
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:32:39:
ColumnarBatch should come before ColumnVector.
[error] Total time: 25 s, completed Jul 10, 2019 7:56:53 AM
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
