dongjoon-hyun commented on a change in pull request #25086: [SPARK-28271][SQL][PYTHON][TESTS] Convert and port 'pgSQL/aggregates_part2.sql' into UDF test base URL: https://github.com/apache/spark/pull/25086#discussion_r302208451
########## File path: sql/core/src/test/resources/sql-tests/inputs/udf/pgSQL/udf-aggregates_part2.sql ########## @@ -0,0 +1,232 @@ +-- +-- Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group +-- +-- +-- AGGREGATES [Part 2] +-- https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/aggregates.sql#L145-L350 Review comment: Please use `REL_12_BETA2` here because BETA2 is already out and more closer to `REL_12`. I guess `REL_12_BETA2` will be the same with `REL_12_BETA1`. If not, please make this up-to-date. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
