dongjoon-hyun commented on a change in pull request #25041: [SPARK-28133][SQL]
Add acosh/asinh/atanh functions to SQL
URL: https://github.com/apache/spark/pull/25041#discussion_r302335063
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
##########
@@ -557,6 +581,28 @@ case class Sin(child: Expression) extends
UnaryMathExpression(math.sin, "SIN")
""")
case class Sinh(child: Expression) extends UnaryMathExpression(math.sinh,
"SINH")
+@ExpressionDescription(
+ usage = """
+ _FUNC_(expr) - Returns inverse hyperbolic sine of `expr`.
+ """,
+ arguments = """
+ Arguments:
+ * expr - hyperbolic angle
+ """,
+ examples = """
+ Examples:
+ > SELECT _FUNC_(0);
+ 0.0
Review comment:
The following is different because PostgreSQL returns `-Infinity`.
```
spark-sql> SELECT asinh(double('-Infinity'));
NaN
Time taken: 0.025 seconds, Fetched 1 row(s)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
