cloud-fan commented on a change in pull request #25104: [SPARK-28341][SQL]
remove session catalog config
URL: https://github.com/apache/spark/pull/25104#discussion_r302336414
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala
##########
@@ -137,13 +144,12 @@ class DataSourceV2SQLSuite extends QueryTest with
SharedSQLContext with BeforeAn
checkAnswer(spark.internalCreateDataFrame(rdd2, table.schema), Seq.empty)
}
- test("CreateTable: use default catalog for v2 sources when default catalog
is set") {
- val sparkSession = spark.newSession()
- sparkSession.conf.set("spark.sql.catalog.testcat",
classOf[TestInMemoryTableCatalog].getName)
- sparkSession.conf.set("spark.sql.default.catalog", "testcat")
- sparkSession.sql(s"CREATE TABLE table_name (id bigint, data string) USING
foo")
+ test("CreateTable: use default catalog when default catalog is set") {
Review comment:
change the test name a little bit, because we will always use default
catalog when the config is set, no matter what the table provider is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
