Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3946#issuecomment-69770778
> Should I remove all the unit tests for thrift server UI? I found u close
all UI tests in #3998
AFAIK, we didn't need to enable the UI in those unit tests in older
branches since it just led to port contention issues and we had no
Thrift-specific tests that relied on the Spark web UI. In your case, I think
we should keep the new tests (more tests are pretty much always better!), but
we should see if there's a way to avoid port-contention issues (maybe by using
a randomized UI port; there might be other tests that do this). Barring
finding a better approach, you could just revert my change in `master` and
leave it in place in the other branches (assuming we're not going to port this
change to `branch-1.2` (1.2.1)).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
