maropu commented on issue #25041: [SPARK-28133][SQL] Add acosh/asinh/atanh functions to SQL URL: https://github.com/apache/spark/pull/25041#issuecomment-510335390 PostgreSQL implementation for asinh: https://github.com/postgres/postgres/blob/b5810de3f4eb0e7b242d31db93a46957d56ea8b4/src/backend/utils/adt/float.c#L2537 It just checks if the result is valid by `check_float8_val(const float8 val, const bool inf_is_valid, const bool zero_is_valid)`: https://github.com/postgres/postgres/blob/b5810de3f4eb0e7b242d31db93a46957d56ea8b4/src/backend/utils/adt/float.c#L2547 For asinh, inf_is_valid=true, so infinity is valid for asinh output. Anyway, +1 for @dongjoon-hyun and I think `-Infinity` is more suitable for the output.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
