HyukjinKwon opened a new pull request #25110: [SPARK-28270][SQL][FOLLOW-UP] 
Explicitly cast into integer/long in udf-aggregates_part1.sql to avoid Python 
float limitation
URL: https://github.com/apache/spark/pull/25110
 
 
   ## What changes were proposed in this pull request?
   
   The tests added at https://github.com/apache/spark/pull/25069 seem flaky in 
some environments. See 
https://github.com/apache/spark/pull/25069#issuecomment-510338469
   
   Python's string representation of floats can make the tests flaky. See 
https://docs.python.org/3/tutorial/floatingpoint.html.
   
   I think it's just better to explicitly cast everywhere udf returns a float 
(or a double) to stay safe.
   
   This PR proposes to cast it to integer to long explicitly to make the test 
cases robust.
   
   ## How was this patch tested?
   
   Manually tested in local.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to