skonto edited a comment on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] 
Convert and port 'group-by.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25098#issuecomment-510695661
 
 
   @HyukjinKwon it seems hard to make all udfs comply with the string output, I 
was thinking of generating one out file per udf. Eg. xxx.out.pandas, 
xxx.out.py, xxx.out.scala, then it would be trivial to compare. Would that be 
acceptable? Of course I will have to generate all the files for the other udfs 
but I think that is the cleanest but more verbose solution, instead of 
overwriting the same file and expect udf outputs to comply. Also this way its 
easier to modify the udfs without caring about consistency at that udf code 
level between different languages. Thoughts? Let me know how you want me to 
proceed with this? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to