xianyinxin commented on issue #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2 URL: https://github.com/apache/spark/pull/25115#issuecomment-510714881 > @xianyinxin thanks for working on it. > > A few general questions: > > 1. do we need individual interfaces for UPDATE/DELETE/... or a single interface? > 2. Is the builder pattern applicable here? To me it's an overkill to simple stuff like DELETE. We may need it for MERGE in the future. > > also cc @brkyvz @jose-torres Thanks @cloud-fan . 1. UPDATE and DELETE is similar, to me make the two in a single interface seems OK. 2. Yes, the builder pattern is considered for complicated case like MERGE. Shall we just simplify the builder for UPDATE/DELETE now or keep it thus we can avoid change the interface structure if we want support MERGE in the future? As `SupportsMaintenance#newMaintainerBuilder` would return a `MaintenanceBuilder`, remove the builder means we let it return `Maintainer` directly. If some days later we need a builder, we then need to modify the interface. My prefer is keep it, what's your opinion?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
