skonto removed a comment on issue #25098: [SPARK-28280][SQL][PYTHON][TESTS] 
Convert and port 'group-by.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25098#issuecomment-510695661
 
 
   @HyukjinKwon it seems hacky/less cleaner to make all udfs comply with the 
string output or using `CAST` I was thinking of generating one out file per 
udf. Eg. xxx.out.pandas, xxx.out.py, xxx.out.scala, then it would be trivial to 
compare. Would that be acceptable? Of course I will have to generate all the 
files for the other udfs but I think that is the cleanest but more verbose 
solution, instead of overwriting the same file and expect udf outputs to 
comply. Also this way its easier to modify the udfs without caring about 
consistency at that udf code level between different languages. Thoughts?  I 
will give it a shot to the unification of the udf output first anyway, but 
wanted to discuss alternatives.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to