srowen commented on a change in pull request #24793: [SPARK-27944][ML] Unify
the behavior of checking empty output column names
URL: https://github.com/apache/spark/pull/24793#discussion_r302970373
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/regression/AFTSurvivalRegression.scala
##########
@@ -355,13 +355,28 @@ class AFTSurvivalRegressionModel private[ml] (
@Since("2.0.0")
override def transform(dataset: Dataset[_]): DataFrame = {
transformSchema(dataset.schema, logging = true)
- val predictUDF = udf { features: Vector => predict(features) }
- val predictQuantilesUDF = udf { features: Vector =>
predictQuantiles(features)}
+
+ var predictionColNames = Seq.empty[String]
Review comment:
These checks seem OK to add for consistency, though I think it still
wouldn't come up unless the user explicitly changed both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
